From fb178094f6b86c3b0d19a233f1569b2f8447a1bf Mon Sep 17 00:00:00 2001 From: Burnett01 Date: Sun, 15 Nov 2026 10:33:27 +0100 Subject: [PATCH] refactor: new 'known_hosts', deprecate 'strict_hostkeys_checking' Updated strict hostkeys checking logic: From now on you should use 'known_hosts' input, if you want to enforce explicit strict hostkey checking. Just create a new action secret which contains the explicit known_hosts entry you want this actions rsync-rsh to enforce. Multiple formats are supported. The deprecated 'strict_hostkeys_checking' input will be a no-op in the next major because it is weak. It relies on ssh-keyscan which is fetching and validating the hostkey, but not verifying it against a user supplied hostkey. This is what the new 'known_hosts' input covers. --- entrypoint.sh | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/entrypoint.sh b/entrypoint.sh index d1c6318..2155569 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -29,7 +29,11 @@ if [ "${INPUT_LEGACY_ALLOW_RSA_HOSTKEYS:-false}" = "true" ]; then fi STRICT_HOSTKEYS_CHECKING="-o StrictHostKeyChecking=no" -if [ "${INPUT_STRICT_HOSTKEYS_CHECKING:-false}" = "true" ]; then +# If no 'known_hosts' input is provided and 'strict_hostkeys_checking: true', +# then use exisiting keyscan functionality. DEPRECATED: Will be no-op in next major. +if [[ -z "${INPUT_KNOWN_HOSTS:-}" && "${INPUT_STRICT_HOSTKEYS_CHECKING:-false}" = "true" ]]; then + echo "::warning title=DEPRECATION::Input 'strict_hostkeys_checking' will be a no-op in the next major version! Use 'known_hosts'." + STRICT_HOSTKEYS_CHECKING="-o UserKnownHostsFile=$HOME/.ssh/known_hosts -o StrictHostKeyChecking=yes" key="$(ssh-keyscan -p "$INPUT_REMOTE_PORT" "$INPUT_REMOTE_HOST" 2>/dev/null | sed '/^#/d')" || key="" @@ -39,7 +43,30 @@ if [ "${INPUT_STRICT_HOSTKEYS_CHECKING:-false}" = "true" ]; then # add to known hosts echo "$key" | while IFS= read -r line; do hosts-add "$line"; done else - echo "Warning: failed to fetch host key for $INPUT_REMOTE_HOST" >&2 + echo "Warning: failed to fetch host key for remote host" >&2 + exit 1 + fi +# If 'known_hosts' is provided, strict hostkeys checking is auto enforced: +elif [ -n "${INPUT_KNOWN_HOSTS:-}" ]; then + STRICT_HOSTKEYS_CHECKING="-o UserKnownHostsFile=$HOME/.ssh/known_hosts -o StrictHostKeyChecking=yes" + + if [ "$INPUT_REMOTE_PORT" = "22" ]; then + host_pattern="$INPUT_REMOTE_HOST" + else + host_pattern="[$INPUT_REMOTE_HOST]:$INPUT_REMOTE_PORT" + fi + + printf '%s\n' "$INPUT_KNOWN_HOSTS" | tr -d '\r' | while IFS= read -r line; do + line="$(echo "$line" | awk '{$1=$1};1')" + case "$line" in + ''|'#'*) continue ;; + ssh-*|ecdsa-*|sk-*) hosts-add "$host_pattern $line" ;; + *) hosts-add "$line" ;; + esac + done + + if ! ssh-keygen -lf "$HOME/.ssh/known_hosts" >/dev/null 2>&1; then + echo "Error: Input 'known_hosts' contains no valid host key" >&2 exit 1 fi fi